[ie/youtube] Attempt to extract title for Shorts from accessibilityText as fallback (#11991) #11997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xt as fallback (yt-dlp#11991) Closes yt-dlp#11991 Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
bashonly
approved these changes
Jan 26, 2025
vladisslav2011
pushed a commit
to vladisslav2011/yt-dlp
that referenced
this pull request
Jan 30, 2025
…lp#11997) Closes yt-dlp#11991 Authored by: d3d9, bashonly Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
See #11991: When Shorts are accessed e. g. through the Shorts subscriptions feed and with --flat-playlist, there is no title available since the property for that is not present. The full title is contained within the present accessibilityText property though, so it is attempted to extract it from there. A test of 2000 feed entries with various types of titles and view counts resulted in 100% recovered titles. Not sure how to approach adding actual test cases for this yet.
Fixes #11991
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?