-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[facebook] ERROR: No video formats found (on >= 2024.11.04) #11497
Comments
The debug output during cookies extraction is a bit concerning; are you sure the facebook cookies are being successfully extracted/passed? Have you tried with |
I didn't, but here's the debug output pulling cookies from chrome giving the same end result without all the cookie parsing output:
|
If you want to add |
Sent to your proton mail. |
I have a similar but maybe different issue. Same kind of response but with a publicly available video. https://www.facebook.com/watch/?v=1085099419908696&rdid=tfjgd4h6VuK74V0w 1085099419908696-560p-סוף שבוע טוב וגם מצחיק קצת 🤣🤣🤣🤣🤣🤣🤣🤣🤣🤣 | By שלמה טל.info.json and this patch get the job done: diff --git a/yt_dlp/extractor/facebook.py b/yt_dlp/extractor/facebook.py
index 2bcb5a841..c4fa88c05 100644
--- a/yt_dlp/extractor/facebook.py
+++ b/yt_dlp/extractor/facebook.py
@@ -566,6 +566,10 @@ def extract_from_jsmods_instances(js_data):
def extract_dash_manifest(video, formats):
dash_manifest = traverse_obj(
video, 'dash_manifest', 'playlist', 'dash_manifest_xml_string', expected_type=str)
+ if not dash_manifest:
+ videoDeliveryResponseFragment = (
+ 'videoDeliveryResponseFragment', 'videoDeliveryResponseResult', 'dash_manifests', 0, 'manifest_xml')
+ dash_manifest = traverse_obj(video, videoDeliveryResponseFragment, expected_type=str)
if dash_manifest:
formats.extend(self._parse_mpd_formats(
compat_etree_fromstring(urllib.parse.unquote_plus(dash_manifest)), Is it PR worthy, or too kludgy. Give me some feedback and I'll submit this |
I manually applied the fix from @refack above to my installation and can confirm my videos are downloading now |
How to run diff --git a/yt_dlp/extractor/facebook.py b/yt_dlp/extractor/facebook.py in Windows? $ diff --git a/yt_dlp/extractor/facebook.py b/yt_dlp/extractor/facebook.py
diff: unknown option -- git |
|
Issue for me as well. |
or https://github.com/yt-dlp/yt-dlp/wiki/Installation#pip-nightly |
DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE
Checklist
Region
US
Provide a description that is worded well enough to be understood
Please note this is not related to #11337 and is new. I had the problem reported in that issue, and it went away for about a week or so after updating to the nightly build. This problem is new in the past week.
I've duplicated this on Windows and Mac, and it appears as though it's specifically related to private group videos. I've tested
--cookies-from-browser
forchrome
,firefox
, andsafari
, all with the same results.If needed, I can invite any developers to the group for troubleshooting, videos are SFW (youth hockey video).
Provide verbose output that clearly demonstrates the problem
yt-dlp -vU <your command line>
)'verbose': True
toYoutubeDL
params instead[debug] Command-line config
) and insert it belowComplete Verbose Output
The text was updated successfully, but these errors were encountered: