Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic assign limiter. #7

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Conversation

ChiahungTai
Copy link
Collaborator

@you-n-g
Add dynamic assign limiter to get_data function.
From my previous experience, the APIs are:

  1. One rate limit to all functions.
  2. Some functions are in A-rate, the others in B-rate.

By the way, the idea of the context manager is a good idea in some cases. In my case, I need to login to use the API, it might suitable for the singleton pattern. But in other case which no need of sharing setting, the context manger version will be a good usage.

@you-n-g you-n-g merged commit 0cff189 into you-n-g:master Dec 7, 2022
@ChiahungTai ChiahungTai deleted the dynamic_limiter branch December 7, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants