feat: add Kind exceptions #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #263 +/- ##
=======================================
Coverage 43.37% 43.37%
=======================================
Files 58 58
Lines 2808 2808
=======================================
Hits 1218 1218
Misses 1400 1400
Partials 190 190 ☔ View full report in Codecov by Sentry. |
yonahd
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR excludes the default resources created in basic
kindinstallations.The only excluded resource in a default service created in macOS installation.
PR Checklist
Github Issue
Closes #235
Notes for your reviewers
I've tested
kindboth on Windows & Linux, and all the default unused resources are already covered bykor(added from other distros exclusions). The only difference is mentioned here but it was added in #252.This PR adds exceptions from macOS installation.