Specify up/down migrate functions with optional args #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow for a vector of custom args to be associated with the up and down migration functions.
migration functions are a symbol, or a vector of symbol plus extra args.
|
Thanks, looks good but I'm noticing a test is failing now. Actually, that looks unrelated to the pr. It's my local docker setup, so I think we're good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The up/down migration function entries in a code-based migration file can optionally be a vector syntax, e.g.
{..., :up-fn [migrate-up "arg1" :arg2], ...}, where the additional args will be passed to the migration function after the config map.