resolve issue in db driver to set delay job #208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#207 PHP Warning 'yii\base\ErrorException' with message 'sleep() expects parameter 1 to be integer, string given'
samdark
reviewed
Feb 8, 2018
| @@ -74,6 +74,7 @@ public function init() | |||
| */ | |||
| public function run($repeat, $delay = 0) | |||
| { | |||
| $delay = intval($delay); | |||
samdark
added
type:bug
samdark
approved these changes
Feb 8, 2018
|
Please add a line to changelog. |
zhuravljov
requested changes
Feb 22, 2018
| @@ -74,6 +74,7 @@ public function init() | |||
| */ | |||
| public function run($repeat, $delay = 0) | |||
| { | |||
| $delay = intval($delay); | |||
There was a problem hiding this comment.
IMHO it is wrong way. $delay param comes from console command as timeout option:
yii2-queue/src/drivers/db/Command.php
Lines 66 to 69 in a97007c
I think, it should be made as timeout param validation:
public function actionListen($timeout = 3)
{
if (!is_numeric($timeout)) {
throw new \yii\console\Exception('Timeout must be numeric.');
}
if ($timeout < 1) {
throw new \yii\console\Exception('Timeout must be greater that zero.');
}
return $this->queue->run(true, $timeout);
}
|
Closing then, won't be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#207
PHP Warning 'yii\base\ErrorException' with message 'sleep() expects parameter 1 to be integer, string given'