Fixed creating built-in validator in model with same function name #14499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dmirogin
commented
Jul 20, 2017
dmirogin
commented
| Q | A |
|---|---|
| Is bugfix? | yes |
| New feature? | no |
| Breaks BC? | no |
| Tests pass? | yes |
| Fixed issues | #14370 |
…h same function name
dynasource
suggested changes
Jul 21, 2017
| /** | ||
| * @see https://github.com/yiisoft/yii2/issues/14370 | ||
| */ | ||
| private function number() |
There was a problem hiding this comment.
shouldnt this be mapped to a configured rule Rules()?
There was a problem hiding this comment.
@dynasource This bug happens when you have function in model class with name that same to one of built-in validators. And Validator::createValidator create InlineValidator instead NumberValidator in this case. I can make separate model class and test for getting this more clear.
There was a problem hiding this comment.
true. It's a bit magical in the current form
cebe
approved these changes
Jul 22, 2017
samdark
approved these changes
Jul 23, 2017
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.