Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added prompt template #145

Merged
merged 5 commits into from
Mar 11, 2023
Merged

added prompt template #145

merged 5 commits into from
Mar 11, 2023

Conversation

ConanChou
Copy link
Contributor

  • added an option for user to tweak the prompt
  • formatted the ChatGPTAPI output, so it match the style with GPT3 and Google

@yihong0618 yihong0618 mentioned this pull request Mar 11, 2023
Merged
@yihong0618
Copy link
Owner

yihong0618 commented Mar 11, 2023 •
edited
Loading

@ConanChou Thanks LGTM
do we need add one test in CI?
and could help me to check can the #144 both work with this?
Thanks a lot

@ConanChou
Copy link
Contributor Author

re: test - yeah, makes sense, didn't realize we have test in the workflow.
re: #144 - i can take a look tomorrow. it's getting late in new york 😴

@zstone12
Copy link
Collaborator

LGTM.The conflict needs to be resolved:D

@yihong0618
Copy link
Owner

re: test - yeah, makes sense, didn't realize we have test in the workflow. re: #144 - i can take a look tomorrow. it's getting late in new york 😴

good night~

@yihong0618
Copy link
Owner

merge first~
Thanks a lot ~

@yihong0618 yihong0618 merged commit b1d62e8 into yihong0618:main Mar 11, 2023
@ConanChou
Copy link
Contributor Author

ConanChou commented Mar 11, 2023 •
edited
Loading

oh cool! thanks, I will continue to finish up the suggested changes

@yihong0618
Copy link
Owner

thanks a lot

@ConanChou
Copy link
Contributor Author

actually I think you have done the above suggested changes. thanks!

I plan to unify the way we set the system and user prompt, making both configurable via using --prompt and system env. Now it's a bit weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ConanChou @yihong0618 @zstone12