Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add txt book loader #143

Merged
merged 5 commits into from
Mar 11, 2023
Merged

feat: add txt book loader #143

merged 5 commits into from
Mar 11, 2023

Conversation

zstone12
Copy link
Collaborator

@zstone12 zstone12 commented Mar 11, 2023 •
edited
Loading

主要参考 #35 实现txt loader。
目前用the_little_prince.txt 测试，效果正常。

TODO：

  • 完善 _save_temp_book 实现
  • txt 类型补充到文档中

@zstone12 zstone12 changed the title [WIP] feat: add txt book loader feat: add txt book loader Mar 11, 2023
@zstone12 zstone12 requested a review from yihong0618 March 11, 2023 03:15
@yihong0618
Copy link
Owner

@zstone12
for this PR I think its OK.
in the future can we batch the lines
like `line1+;;;+line2+;;;+line3+;;; -> to bantch translate -> back we split it then add to the book?
txt is relatively better to control

@yihong0618 yihong0618 merged commit aaa1ab4 into yihong0618:main Mar 11, 2023
@zstone12
Copy link
Collaborator Author

@zstone12 for this PR I think its OK. in the future can we batch the lines like `line1+;;;+line2+;;;+line3+;;; -> to bantch translate -> back we split it then add to the book? txt is relatively better to control

@yihong0618 This sounds better, it will improve efficiency, and we can complete it in the later work.

@zstone12
Copy link
Collaborator Author

@DennySORA This PR is based on your work. Thanks for your previous work.

wayhome pushed a commit to wayhome/bilingual_book_maker that referenced this pull request Aug 29, 2024
@bookfere
Merge pull request yihong0618#143 from miiPoP/master
9881202 
compiled fr.po
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihong0618 yihong0618 Awaiting requested review from yihong0618

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zstone12 @yihong0618