Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve README #119

Merged
merged 3 commits into from
Mar 9, 2023
Merged

Improve README #119

merged 3 commits into from
Mar 9, 2023

Conversation

typebrook
Copy link
Contributor

@typebrook typebrook commented Mar 8, 2023

  • Improve English wording
  • Surround command, files , terms with ` `(backticks)
  • In each codeblock, make comment starts from capitalized char
  • command/parameter -> option
  • Add description about --translate-tags from PR support translate other than <p> #107

- Improve English wording
- Surround command, files , terms with "`"
- In codeblock, make comment starts from capitalized char
- command/parameter -> option
- Add description about --translate-tags from PR#107
@yihong0618
Copy link
Owner

yihong0618 commented Mar 9, 2023

@can you use simplified Chinese or add another README for Traditional Chinese~
Sorry for the inconvenience

@typebrook
Copy link
Contributor Author

Sorry, my bad. I don't distinguish simplified/traditional Chinese in my head when typing.

I'll change them to simplified Chinese in README-CN.md

@typebrook
Copy link
Contributor Author

DONE
c6bf631

README-CN.md Outdated Show resolved Hide resolved
README-CN.md Outdated Show resolved Hide resolved
@yihong0618
Copy link
Owner

Its always interesting to find the difference about simplified Chinese and Traditional Chinese
image

@typebrook
Copy link
Contributor Author

typebrook commented Mar 9, 2023

So true! Check this blog if you are interested:
https://byvoid.com/zht/categories/語言文字/
https://byvoid.com/zht/blog/region-phrases-comparison-transistor/

@yihong0618 yihong0618 merged commit 26fdfb0 into yihong0618:main Mar 9, 2023
zhimiaoli added a commit to zhimiaoli/bilingual_book_maker that referenced this pull request Mar 9, 2023
@typebrook typebrook deleted the README branch March 9, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants