Update README.md about FastRunningMedian NaN Handling #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of v0.2.1, FastRunningMedian doesn't output garbage with NaNs anymore 🎉 (tracking issue: Firionus/FastRunningMedian.jl#21). I've adjusted the README slightly to include this information.
|
Thanks 👍 |
|
That's funny, I als thought it would be really hard 😂:
But once I delved into it, things somehow just fell into place 🤷♂️ Have a nice day 🌻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey yha 👋,
great job with this package! It seems to do exactly what it says on the box and the implementation is super elegant 👍. I've stumbled across it while searching for my package FastRunningMedian and it was interesting that you also were affected by the garbage output with NaN values. However, as of v0.2.1, FastRunningMedian doesn't output garbage with NaNs anymore 🎉 (tracking issue: Firionus/FastRunningMedian.jl#21).
I've adjusted the README slightly to include this information.
Rock on 😃