Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openai): add backward compat for get_user_message #813

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

BruceChen7
Copy link
Contributor

opts.message is of type AvanteLLMMessage. The message.content field should be used. Otherwise, table.concat(opts.messages) will fail.

@BruceChen7
Copy link
Contributor Author

@yetone Can you help confirm this issue? Version 0.0.8 doesn't have this problem, but version 0.0.9 introduced it.

@aarnphm
Copy link
Collaborator

aarnphm commented Nov 7, 2024

Are you using get_user_message in your custom providers?

since I don't think we use this anywhere

Copy link
Collaborator

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny

lua/avante/providers/openai.lua Outdated Show resolved Hide resolved
@BruceChen7
Copy link
Contributor Author

Are you using get_user_message in your custom providers?

since I don't think we use this anywhere

Yes, I use it in custom providers.

@aarnphm aarnphm changed the title fix: fix openai get_user_message fix(openai): add backward compat for get_user_message Nov 7, 2024
@aarnphm aarnphm merged commit ec9b00d into yetone:main Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants