Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support legacy finish_reason #706

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

abatilo
Copy link
Contributor

@abatilo abatilo commented Oct 11, 2024

Many OpenAI compatible alternative servers are still returning a
finish_reason of eos_token instead of stop. This commit adds
support for that to support more of these servers/options.

Many OpenAI compatible alternative servers are still returning a
`finish_reason` of `eos_token` instead of `stop`. This commit adds
support for that to support more of these servers/options.
@yetone yetone changed the title Support legacy finish_reason fix: support legacy finish_reason Oct 11, 2024
@yetone yetone merged commit f92c3a6 into yetone:main Oct 11, 2024
5 checks passed
@abatilo abatilo deleted the abatilo/legacy-oai-stop-reason branch October 11, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants