Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider): initial error handling on claude #221

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

Munsterberg
Copy link
Contributor

@Munsterberg Munsterberg commented Aug 26, 2024

Wasn't the only one running into this issue and it's more prominent due to how these companies are handling their API usage now. Can see an example in #117. Will likely have to improve this at some point and support more cases, but these seem to be the two most common problems that people run into with no feedback

lua/avante/llm.lua Outdated Show resolved Hide resolved
Copy link
Collaborator

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have a providers.on_error function instead of this.

@Munsterberg
Copy link
Contributor Author

Munsterberg commented Aug 26, 2024

I think we should have a providers.on_error function instead of this.

whipped up what you suggested. Was gonna add a default case for on_error since I don't have too much time, but if you want I can slowly handle cases this week for other providers -- will just take me a while

@Munsterberg Munsterberg force-pushed the fix/improve-error-handling branch 2 times, most recently from 65abb27 to 7ca4238 Compare August 26, 2024 01:12
@Munsterberg Munsterberg force-pushed the fix/improve-error-handling branch from 7ca4238 to d680f95 Compare August 26, 2024 01:14
Copy link
Collaborator

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do it iteratively. I think this is a good start

@aarnphm aarnphm changed the title fix: improve error handling for common issues feat(error): initial error handling on claude Aug 26, 2024
@aarnphm aarnphm changed the title feat(error): initial error handling on claude feat(provider): initial error handling on claude Aug 26, 2024
@aarnphm aarnphm merged commit 312543b into yetone:main Aug 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants