multi platform automated docker builds #16
Conversation
iloveitaly
commented
Jul 22, 2024
iloveitaly
commented
- multi platform gh actions docker build
- docs: httpie example
|
@yegor256 this is looking good! Let me know what you think. |
.github/workflows/docker.yml
Outdated
| type=ref,event=branch | ||
| type=ref,event=pr | ||
| type=semver,pattern={{version}} | ||
| type=semver,pattern={{major}}.{{minor}} |
There was a problem hiding this comment.
@iloveitaly I'm curious, where will these version, major, and minor come from?
There was a problem hiding this comment.
these are autogen'd from the PR. They aren't great, so we could remove if you want.
There was a problem hiding this comment.
@iloveitaly I don't know what would be a better solution... Maybe let's just increment the version and that's it? Every new push to master generates a new version in Docker Hub. Just a number, no major, no minor -- only an integer. Is it possible?
|
Swap the Ubuntu version out. Let me know if anything else is needed here. |
| type=ref,event=pr | ||
| type=semver,pattern={{version}} | ||
| type=semver,pattern={{major}}.{{minor}} | ||
| type=sha |
There was a problem hiding this comment.
Agh, I'm not really sure how to do that. Maybe we should just remove them for now since we have the latest and sha tag to start with? And then one of us can figure out how to get proper semver in place?
There was a problem hiding this comment.
@iloveitaly sounds right, just latest is enough
|
@iloveitaly thanks, let's see how it works |
