This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
update/0.3.0 #58
Merged
update/0.3.0 #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djrtwo
reviewed
Feb 25, 2019
| func isActive(epoch: EpochNumber) -> Bool { | ||
| return self.activationEpoch <= epoch && epoch < self.exitEpoch | ||
| func isActive(epoch: Epoch) -> Bool { | ||
| return activationEpoch <= epoch && epoch < exitEpoch |
| @@ -254,17 +254,17 @@ extension StateTransition { | |||
| } | |||
|
|
|||
| static func exits(state: inout BeaconState, block: BeaconBlock) { | |||
There was a problem hiding this comment.
Might consider renaming voluntary_exits
|
|
||
| assert(state.slot == transfer.slot) | ||
| assert(BeaconChain.getCurrentEpoch(state: state) >= state.validatorRegistry[Int(transfer.from)].withdrawableEpoch) | ||
| // @todo does this work (-1)? |
There was a problem hiding this comment.
If it does work, wouldn't it be 1 ..<= -1 so you include the last element?
There was a problem hiding this comment.
@djrtwo found something even nicer: https://developer.apple.com/documentation/foundation/data/1779685-suffix
| @@ -297,7 +340,7 @@ extension StateTransition { | |||
| extension StateTransition { | |||
|
|
|||
| static func processEpoch(state: inout BeaconState) { | |||
| assert(state.slot + 1 % EPOCH_LENGTH == 0) // @todo not sure if this should be here | |||
| assert(state.slot + 1 % SLOTS_PER_EPOCH == 0) // @todo not sure if this should be here | |||
There was a problem hiding this comment.
You should only call this function if that condition holds. Seems a little redundant to assert it here but not necessarily incorrect
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.