fix(fslib): support utf8 buffers #4943
Merged
+137
−42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
We don't support path
Buffer
s in@yarnpkg/fslib
.Fixes #1818.
Supersedes:
toPortablePath
#4914.How did you fix it?
Renamed
URLFS
toNodePathFS
and implemented support for mappingBuffer
s to strings.We currently only support valid utf8 buffers because binary buffers cannot be supported without keeping the paths as buffers until the end (see #4907 (comment)).
Because of this, we now throw an error when encountering buffers that cannot be encoded as utf8 and encourage users to upvote this issue so that we can gather how common non-utf8 buffers are.
The check uses
Buffer.byteLength
(credit to @arcanis for coming up with this idea) instead ofBuffer.compare
since the latter is quite slower.Checklist