Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(fslib): early return when callback is undefined #4114

Merged
merged 2 commits into from
Feb 15, 2022
Merged

refactor(fslib): early return when callback is undefined #4114

merged 2 commits into from
Feb 15, 2022

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Feb 14, 2022

What's the problem this PR addresses?

While going through source code of fslib, I noticed that return can be called early when callback is undefined.

How did you fix it?

Calls return early when callback is undefined

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit af6bfbb into yarnpkg:master Feb 15, 2022
@trivikr trivikr deleted the trivikr/fslib/xfs-cb-undefined-early-return branch March 9, 2022 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trivikr @arcanis