Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(fslib): change method declaration to const #4104

Merged
merged 4 commits into from
Feb 15, 2022
Merged

refactor(fslib): change method declaration to const #4104

merged 4 commits into from
Feb 15, 2022

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Feb 13, 2022

What's the problem this PR addresses?

Variable method is block scoped using let and being reassigned a value in if-else.

How did you fix it?

Uses const for variable method, and converts if-else to conditional operator.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz merceyz changed the title chore(fslib): change method declaration to const refactor(fslib): change method declaration to const Feb 13, 2022
@trivikr @merceyz
chore: remove brackets from conditional operator statement
bec839f 
Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com>
@trivikr trivikr requested a review from merceyz February 14, 2022 01:49
@arcanis arcanis merged commit 7c3f1fb into yarnpkg:master Feb 15, 2022
@trivikr trivikr deleted the trivikr/fslib/method-const branch March 9, 2022 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merceyz merceyz Awaiting requested review from merceyz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trivikr @merceyz @arcanis