Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fslib): replace deprecated isDate #4068

Merged
merged 3 commits into from
Feb 4, 2022

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Feb 4, 2022

What's the problem this PR addresses?

util.isDate() is deprecated since node@v4.0.0, and is replaced by util.types.isDate()
Docs: https://nodejs.org/api/util.html#utilisdateobject

How did you fix it?
Replace occurrence of util.isDate() with util.types.isDate()

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com>
@merceyz merceyz merged commit 3443cfa into yarnpkg:master Feb 4, 2022
@merceyz
Copy link
Member

merceyz commented Feb 4, 2022

Thank you

@trivikr trivikr deleted the trivikr/chore/fslib/zipFS/isDate branch February 5, 2022 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants