Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed druid dimension loader issue. #909

Merged
merged 5 commits into from
May 23, 2019

Conversation

michael-mclawhorn
Copy link
Contributor

Should resolve issue with stuck in time druid dimension loader.

@@ -0,0 +1,58 @@
package com.yahoo.bard.webservice.application
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Header

Copy link
Contributor

@will-lauer will-lauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a copyright in the test file.

Shouldn't checkstyle be checking for an appropriate copyright and give a build failure?

@archolewa archolewa dismissed will-lauer’s stale review May 23, 2019 18:52

Will's on vacation, and his concerns have been addressed.

@michael-mclawhorn michael-mclawhorn merged commit a723053 into master May 23, 2019
@michael-mclawhorn michael-mclawhorn deleted the DruidValueLoaderImprovements branch September 20, 2019 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants