Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠ Danger! Danger! envtpl is no longer maintained! ⚠ #159

Closed
1 of 4 tasks
greg0ire opened this issue Jun 9, 2019 · 3 comments
Closed
1 of 4 tasks

⚠ Danger! Danger! envtpl is no longer maintained! ⚠ #159

greg0ire opened this issue Jun 9, 2019 · 3 comments
Assignees
@TheLocehiliosan
Labels
feature
Milestone
2.0.0

Comments

@greg0ire
Copy link

greg0ire commented Jun 9, 2019 •
edited
Loading

This issue is about

  • Man pages or command-line usage
  • Website documentation
  • Packaging
  • Other (dependencies)

Describe the issue

I tried to use the jinja template functionality, and my first experience was a crash because of non-ASCII chars in the template. The thing is, I would very much like to use non-ASCII chars, so I looked at the stack trace and saw that the issue was in envtpl, one of your dependencies. I managed to fix the issue, and made a PR, only to find that the author has dropped the ball on maintaining this lib.

The choices are:

  • do nothing and let all the bugs in envtpl affect yadm;
  • drop the templating functionality;
  • offer to maintain envtpl and get ownership on it;
  • fork envtpl and maintain that fork;
  • find another jinja2 processor in python.

What is it going to be?
@TheLocehiliosan
Copy link
Member

Thanks for reporting that. I’ll look into adding support for j2cli.

@malikoth
Copy link

FWIW, I tried installing j2cli, and then I replaced line 227 of yadm with

j2 -e= "$tracked_file" > "$real_file"

And it worked flawlessly out of the box.

I tried putting together a PR that would be backwards-compatible and use envtpl if it was available, and j2 otherwise if it was available. I couldn't get it working, because I'm no good at bash. >< But j2cli really does work right out of the box, and it already contains the necessary encoding support to solve greg0ire 's problem with envtpl.

We'd love to see you work your magic and get this in. j2cli really seems much more well-thought-out and usable than envtpl, plus is still under active development.

@dngray dngray mentioned this issue Aug 10, 2019
Open
@TheLocehiliosan
Copy link
Member

Now in the develop branch, if j2cli is available, it is used to process jinja templates.

@TheLocehiliosan TheLocehiliosan self-assigned this Oct 6, 2019
@TheLocehiliosan TheLocehiliosan added this to the 2.0.0 milestone Oct 6, 2019
@KyleKing KyleKing mentioned this issue Aug 2, 2022
Closed
4 tasks
@erijo erijo mentioned this issue Nov 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheLocehiliosan TheLocehiliosan

Labels
feature
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
3 participants
@greg0ire @TheLocehiliosan @malikoth