-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More generators #337
More generators #337
Conversation
Advanced Equipment v0.5.2 RC1
Advanced Equipment v0.5.2 final
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The small red generator should have the same features as the rugged example, see comments.
Also the reported output watts are in very high numbers. We should output kilo watts (kW) instead of watts (W) in case of watts above 1.000. That would be earier to read instead of counting zeros.
Also we should start documenting the assets in the wiki. Could you start and create a page containing the features of the generators? I will add all other assets later. Perhaps our initial google spreadsheet will help you on that: https://docs.google.com/spreadsheets/d/1uKQK8no6wsR7n2-Xa8Vi-e6YC-xwoeOwcBT4-IKHopQ/edit?usp=share_link
All after all the PR looks good to me. You can merge the pull request after you made the mentioned minor changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. You can merge this pull request.
Implemented all other vanilla generator objects: