Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More generators #337

Merged
merged 11 commits into from
Feb 22, 2023
Merged

More generators #337

merged 11 commits into from
Feb 22, 2023

Conversation

GermanHydrogen
Copy link
Collaborator

Implemented all other vanilla generator objects:

  • Radar Generator
  • Diesel Ground Power Unit
  • Power Generator
  • Portable Generator

@GermanHydrogen GermanHydrogen added enhancement New feature or request power issues related to power system labels Feb 19, 2023
@GermanHydrogen GermanHydrogen self-assigned this Feb 19, 2023
@y0014984 y0014984 marked this pull request as ready for review February 21, 2023 15:02
Copy link
Owner

@y0014984 y0014984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The small red generator should have the same features as the rugged example, see comments.

Also the reported output watts are in very high numbers. We should output kilo watts (kW) instead of watts (W) in case of watts above 1.000. That would be earier to read instead of counting zeros.

Also we should start documenting the assets in the wiki. Could you start and create a page containing the features of the generators? I will add all other assets later. Perhaps our initial google spreadsheet will help you on that: https://docs.google.com/spreadsheets/d/1uKQK8no6wsR7n2-Xa8Vi-e6YC-xwoeOwcBT4-IKHopQ/edit?usp=share_link

All after all the PR looks good to me. You can merge the pull request after you made the mentioned minor changes.

Copy link
Owner

@y0014984 y0014984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. You can merge this pull request.

@GermanHydrogen GermanHydrogen merged commit 4e63ec5 into dev Feb 22, 2023
@GermanHydrogen GermanHydrogen deleted the more-generators branch February 22, 2023 18:18
@y0014984 y0014984 mentioned this pull request Jul 11, 2023
22 tasks
@y0014984 y0014984 mentioned this pull request Jul 26, 2023
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request power issues related to power system
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants