DeleteSet: optimize GC squash for improved performance #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Significantly improves performance during GC by batching squashes. - Internal benchmarks with ~34,000 GC block cells reduced runtime from 118s to 400ms (~300x speedup) in release builds.
MarkJGx
changed the title
|
Thanks @MarkJGx . That sounds fantastic :) I'll review (and hopefully merge) it over the weekend. |
Horusiath
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set introduces an optimization to Yrs garbage collection squashing.
Details
To further enhance the scalability of the garbage collection (GC) process in DeleteSet, we've introduced a bulk squashing method that optimizes performance when handling large quantities of GC block cells. The previous per-block handling of squash calls worked well for many use cases. By implementing bulk squashing, we aim to reduce the overhead from constant reallocations while removing individual BlockCells (both GC and Block types).
Results
In our internal benchmark focusing on contiguous removals, we observed that the delete operation GC collection time decreased from 118 seconds to 400 milliseconds in release builds, representing a substantial performance improvement. (Please note, the benchmark uses proprietary types and cannot be shared publicly at this time.)