Undo manager transactions #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// a read-only transaction itself. If transaction couldn't be acquired (because another | ||
| /// read-write transaction is in progress), it will hold current thread until, acquisition is | ||
| /// available. | ||
| pub fn clear(&mut self) { |
There was a problem hiding this comment.
It looks like there is no try_clear(), as you did for other methods?
There was a problem hiding this comment.
Yes, I'll need to add that in subsequent release. As of now, it will block current thread but only if there's a pending read-write transaction (since clear only requires a readonly access.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies several changes:
UndoManagerundo/redo methods are now split to resemble new async capabilities of document store:try_undo/try_redowill try to obtain underlying document store transaction and return error on failure.undo_blocking/redo_blockingwill obtain transactions, waiting by blocking the thread if necessary.undo/redonow returns futures that will obtain transactions asynchronously.yundo_manager_can_undoandyundo_manager_can_redoare now replaced byyundo_manager_undo_stack_lenandyundo_manager_redo_stack_len.