add tests for transact in multi-threaded behaviour #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
| let t = txt.clone(); | ||
| let b = barrier.clone(); | ||
| std::thread::spawn(move || { | ||
| // let mut txn = d.try_transact_mut().unwrap(); // this will hang forever |
There was a problem hiding this comment.
From this comment:
Transact::transactandTransact::transact_mutmethods now won't panic when transaction couldn't be acquired. Instead they will block a thread. You can always simulate old behaviour by usingdoc.try_transact().unwrap().
I understood that d.try_transact_mut().unwrap() will panic (for all other threads after the first one acquired the transaction), not that it will hang forever?
There was a problem hiding this comment.
In this case it will hang forever, since panic inside of the thread will prevent execution of barrier.wait(), which means that we won't be able to pass over the barrier on the main test thread.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.