Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SharedRef types Send + Sync #438

Closed
Horusiath opened this issue May 13, 2024 · 1 comment
Closed

Make SharedRef types Send + Sync #438

Horusiath opened this issue May 13, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@Horusiath
Copy link
Collaborator

Shared refs like MapRef, ArrayRef etc. should implement Send + Sync traits. Currently it's not a thing due to internal representation MapRef(NonNull<Branch>) (non-null pointers don't implement these traits). We could change that to MapRef(Weak<Branch>) which would be already aligned with how Arc<Branch> is stored in within document store.
@Horusiath Horusiath added the enhancement New feature or request label May 13, 2024
@Horusiath Horusiath mentioned this issue Jun 25, 2024
Closed
12 tasks
@Horusiath
Copy link
Collaborator Author

Solved by #440 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Horusiath