BUG: Remove duplicated call of model_install #2457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Left from commit 7b1f0b4
qinxuye
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
由于有反馈说 xinference-local 变慢。
在 PR #2443 修改了 model install 的方式, 没注意到 deploy/supervisor.py 里面有一个显式的重复调用，现在移除。
实测确认无论改还是不改，实际 xinference/model/init.py 的 _install 方法都只会执行一次, 即使把PR #2443 revert, xinference-local的启动速度也并无明显差别。
Fixes #2460 .