Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit conv3d #3

Merged
merged 81 commits into from
Sep 15, 2023
Merged

Edit conv3d #3

merged 81 commits into from
Sep 15, 2023

Conversation

vmoens
Copy link

@vmoens vmoens commented Sep 7, 2023

Some fixes in the conv3d branch
@xmaples let me know if they make sense!

degensean and others added 30 commits July 19, 2023 19:17
@degensean
[BugFix] Fix bug in ppo example config (pytorch#1396)
c96227a
@vmoens
[BugFix] Fix ppo training NaN occurences (pytorch#1403)
01f602e
@matteobettini
[Example] Multiagent examples: MAPPO-IPPO-MADDPG-IDDPG-IQL-QMIX-VDN (p…
40a0929 
…ytorch#1027)

Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini
[BugFix] Reward sum custom key (pytorch#1413)
6641791 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@vmoens
[Refactor] Use masking in collectors (pytorch#1412)
3558061
@albertbou92
[BugFix] Pickable buffer (pytorch#1410)
3f4e9aa
@matteobettini @vmoens
[Tutorial] Multiagent PPO tutorial (pytorch#1385)
d41e960 
Signed-off-by: Matteo Bettini <matbet@meta.com>
Co-authored-by: Vincent Moens <vincentmoens@gmail.com>
@matteobettini
[Refactor] Remove loss device (pytorch#1395)
c06ed70 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@smorad
[BugFix] Fix LSTM use with padded/masked segments (pytorch#1399)
dc8b7b5
@matteobettini
[CI] Fix tuto deps (pytorch#1416)
e8765c2
@vmoens
[BugFix] unlock in tensordictmodules tests (pytorch#1417)
fc8fe4c
@matteobettini
[Feature] VMAS obs dict (pytorch#1419)
c693199 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini @vmoens
[BugFix] Fix LazyStackedCompositeSpec and introducing `consolidate_…
575a0a4 
…spec` (pytorch#1392)

Signed-off-by: Matteo Bettini <matbet@meta.com>
Co-authored-by: vmoens <vincentmoens@gmail.com>
@vmoens
[BugFix] Fix KLTransform execution with LSTM (pytorch#1426)
8ad72c9
@vmoens
[Versioning] Python 3.11 (pytorch#1433)
0bd26f4
@vmoens
python 3.11 in README (pytorch#1434)
bbf5545
@smorad
[BugFix] Fix QValueModule multi_one_hot (pytorch#1439)
71fd4c2
@matteobettini
[Feature] Optional mapping of "state" in gym specs (pytorch#1431)
e8e8e43 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@vmoens
[BugFix] Fix split_trajs (pytorch#1444)
532ef76
@vmoens
[Test] Test split trajs (pytorch#1445)
83dfff3
@matteobettini @vmoens
[Feature] Heterogeneous Environments compatibility (pytorch#1411)
b210665 
Signed-off-by: Matteo Bettini <matbet@meta.com>
Co-authored-by: vmoens <vincentmoens@gmail.com>
@matteobettini
[Tests] Collector compatibility for heterogeneous environments (pytor…
7b21e52 
…ch#1414)
@osalpekar
Fix MacOS Mujoco Failure (pytorch#1450)
2fe836c
@vmoens
[BugFix] Fix Cython for D4RL (pytorch#1429)
e39e701
@vmoens
[Feature] IsaacGymEnvs integration (pytorch#1443)
6316a57
@matteobettini @vmoens
[Benchmark] Benchmark number GPU vectorised environments in VMAS (Tor…
892ff47 
…chRL vs RLlib) (pytorch#1446)

Signed-off-by: Matteo Bettini <matbet@meta.com>
Co-authored-by: vmoens <vincentmoens@gmail.com>
@vmoens
[Feature] Auto-DoubleToFloat (pytorch#1442)
a01d79d
@vmoens
[Refactor] Change objectives parameter/buffer/target logic (pytorch#1424
c12d8bc 
)
@btx0424
[BugFix] CompositeSpec.unsqueeze (pytorch#1464)
bd316e9
@matteobettini
[BugFix] Discrete SAC rewrite (pytorch#1461)
78b2bb2 
Signed-off-by: Matteo Bettini <matbet@meta.com>
vmoens and others added 9 commits September 6, 2023 20:54
@vmoens
[BugFix] Empty-spec tolerance (pytorch#1501)
2e91643
@kushaangupta
[Doc] correct typos in pendulum tutorial (pytorch#1502)
153337e
@matteobettini @vmoens
[Feature] Making action masks compatible with q value modules and e-g…
786020d 
…reedy (pytorch#1499)

Signed-off-by: Matteo Bettini <matbet@meta.com>
Co-authored-by: Vincent Moens <vincentmoens@gmail.com>
@matteobettini
[BugFix] Fix DDPG squeezing (pytorch#1487)
d8504e7 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@vmoens
[Feature] ClipTransform + rename min/maximum -> low/high (pytorch…
bca6adf 
…#1500)
@matteobettini @vmoens
[BugFix] Multiagent "auto" entropy fix in SAC (pytorch#1494)
4c50f1e 
Signed-off-by: Matteo Bettini <matbet@meta.com>
Co-authored-by: Vincent Moens <vincentmoens@gmail.com>
@vmoens
[Minor] More efficient SAC v1 (pytorch#1507)
435584e
@vmoens
Merge branch 'main' into HEAD
519975b 
# Conflicts:
#	test/test_modules.py
#	test/test_transforms.py
@vmoens
[BugFix] Fix ClipTransform device (pytorch#1508)
d2e11bf
@vmoens
Copy link
Author

vmoens commented Sep 7, 2023

The PR is a bit crazy but it should be simpler if you git merge origin/main :)

@vmoens vmoens mentioned this pull request Sep 8, 2023
Merged
4 tasks
osalpekar and others added 14 commits September 8, 2023 13:33
@osalpekar @vmoens
[CI] Remove CCI Config (pytorch#1456)
162c26f 
Co-authored-by: vmoens <vincentmoens@gmail.com>
@vmoens
[Performance] Miscellaneous efficiency improvements (pytorch#1513)
147de71
@matteobettini @vmoens
[Environment] Petting zoo (pytorch#1471)
a73428b 
Signed-off-by: Matteo Bettini <matbet@meta.com>
Co-authored-by: vmoens <vincentmoens@gmail.com>
@matteobettini
[CI] Fix CI PettingZoo (pytorch#1528)
274cdfc 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@vmoens
[BugFix] Fix envpool (pytorch#1530)
da50587
@matteobettini @vmoens
[Environment, Docs] SMACv2 and docs on action masking (pytorch#1466)
5f3741b 
Signed-off-by: Matteo Bettini <matbet@meta.com>
Co-authored-by: vmoens <vincentmoens@gmail.com>
@vmoens
[CI] Fix CI (pytorch#1529)
1182f46
@matteobettini
[BugFix] Small patches to SMAC (pytorch#1533)
98da063 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@vmoens
[Refactor] Expose all wrappers in torchrl.envs (pytorch#1532)
dbf92c8
@vmoens
[Test] Skip tests in python 3.11 (pytorch#1535)
9804ab4
@vmoens
[BugFIx] Fix entropy signature in truncated normal (pytorch#1536)
dbfce8c
@vmoens
[CI] Fix habitat CI (pytorch#1537)
1060222
@vmoens
[Test] Test state_dict and loss modules (pytorch#1527)
43b943e
@vmoens
Merge branch 'main' into edit_conv3d
3fcd563
@vmoens vmoens merged commit 3fcd563 into xmaples:patch-3 Sep 15, 2023
@vmoens vmoens deleted the edit_conv3d branch September 15, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@vmoens @degensean @matteobettini @albertbou92 @smorad @osalpekar @btx0424 @BY571 @skandermoalla @kushaangupta