Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial gtk4 migration #39

Merged
merged 50 commits into from
Nov 22, 2023
Merged

Initial gtk4 migration #39

merged 50 commits into from
Nov 22, 2023

Conversation

ochibani
Copy link
Collaborator

I tried to minimize code changes it's not working yet, but can be a good starting point.
The window size is not the same as the gtk3 version, probably something wrong in main.ui file.
FileChooserButton not the same as the gtk3 we can make it look and act the same as old version, but I don't think this is useful.
We need to replace Appindicator

@xlmnxp
Copy link
Owner

xlmnxp commented Sep 25, 2022

I suggest to remove libappindicator support

@xlmnxp
Copy link
Owner

xlmnxp commented Oct 14, 2022

feature (#37): included in this PR

@ochibani
Copy link
Collaborator Author

ochibani commented Oct 14, 2022

I believe we need to do this tasks to have working X11 version.
Stable X11 version:

  • Fix progress dialog (“not doing its job correctly”).
  • Fix play button (“xdg-open return no such file or directory”).
  • Fix some Gtk messages related to “main.ui”.
  • Fix is_file_already_exists function.
  • Return missing video formats to combo box.(Not really fixed)
  • A̶d̶d̶ i̶n̶d̶i̶c̶a̶t̶o̶r̶ f̶u̶n̶c̶t̶i̶o̶n̶a̶l̶i̶t̶y̶.(dropped)
  • Add timer to header bar.

@xlmnxp
Copy link
Owner

xlmnxp commented Oct 18, 2022

@ochibani I fixed colors of button select and area selector to use theme colors

@ochibani
Copy link
Collaborator Author

Select a Window is not supported in Wayland due to security measures.

@xlmnxp
Copy link
Owner

xlmnxp commented Oct 18, 2022

@ochibani that wired
I know discord, slack, brave and others support select window

@ochibani
Copy link
Collaborator Author

Audio recording not working in old version gtk3 due to how record button function works, so I removed the audio only record functionality as it's not core functionality for blue recorder.

@xlmnxp
Copy link
Owner

xlmnxp commented Nov 22, 2023

Thank you, I will merge your changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants