Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a User-Agent string (twitterdev-search-tweets-python/version) to … #32

Merged
merged 2 commits into from
Apr 17, 2018
Merged

add a User-Agent string (twitterdev-search-tweets-python/version) to … #32

merged 2 commits into from
Apr 17, 2018

Conversation

fionapigott
Copy link
Contributor

…the request header (#30)

@CLAassistant
Copy link

CLAassistant commented Apr 16, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@binaryaaron binaryaaron self-requested a review April 16, 2018 20:52
binaryaaron
binaryaaron suggested changes Apr 17, 2018
View reviewed changes
Copy link
Contributor

@binaryaaron binaryaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind bumping the program minor version as this is an enhancement?

@fionapigott
Copy link
Contributor Author

fionapigott commented Apr 17, 2018 •
edited
Loading

@binaryaaron bumped the version to 1.7.0
The only place I have to change it is in the version file, yeah?

binaryaaron
binaryaaron approved these changes Apr 17, 2018
View reviewed changes
Copy link
Contributor

@binaryaaron binaryaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@binaryaaron binaryaaron merged commit 4f73166 into master Apr 17, 2018
@binaryaaron binaryaaron deleted the ua-string branch April 17, 2018 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binaryaaron binaryaaron binaryaaron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fionapigott @CLAassistant @binaryaaron