search_tweets.py environment detection fix #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jrmontag
approved these changes
Apr 12, 2018
There was a problem hiding this comment.
These changes look great @binaryaaron. Thanks for the fast turn-around.
|
@binaryaaron one other observation I had: it looks to me like the CLI section in the main repo readme ( https://github.com/twitterdev/search-tweets-python/blob/script_env_fix/README.rst#using-the-comand-line-application ) hasn't been updated to match the text in 0d277d4 is that something that makes sense to add to this PR? |
|
@jrmontag - that was an oversight on my part; I didn't rebuild the docs / readme. Thanks for the catch. |
|
closes #25. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
referencing #25 - I've added the proper shebang and updated documentation to remove references for running this script from the
toolsdirectory.