Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari custom color picker errors out on browser check #906

Closed
pmasekito opened this issue Nov 30, 2022 · 1 comment · Fixed by #907
Closed

Safari custom color picker errors out on browser check #906

pmasekito opened this issue Nov 30, 2022 · 1 comment · Fixed by #907

Comments

@pmasekito
Copy link
Contributor

Jodit Version: 3.22.1

Browser: Safari
OS: MacOS

Reproducible on the playground page: https://xdsoft.net/jodit/play.html

Expected behavior:
On Safari, when I click the teardrop to change the color of whatever in the editor, the custom color palette button should display but doesn't.

Actual behavior:
When I click the teardrop to change the color of whatever in the editor, the custom color picker palette doesn't display like it does on Safari or Mozilla. It's due to the type check in has-browser-color-picker.ts for a.selectionStart. That creates a TypeError on Safari (but is null on other browsers.) and that TypeError just gets thrown to the catch block.

@pmasekito
Copy link
Contributor Author

Commenting to get an update on this - thanks!

@xdan xdan closed this as completed in #907 Dec 17, 2022
xdan added a commit that referenced this issue Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant