[Phase] Implement Xcode 16.0 beta 1-6 changes. #21156

rolfbjarne · 2024-08-30T14:12:17Z

Note: there were no changes in beta 2, beta 3, beta 4, beta 5 or beta 6.

github-actions · 2024-08-30T14:16:07Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

…1-phase

mcumming · 2024-09-11T12:59:13Z

src/AudioToolbox/AudioType.cs

+	[SupportedOSPlatform ("tvos")]
+#endif
+	[StructLayout (LayoutKind.Sequential)]
+	public unsafe readonly ref struct AudioBufferList {


Is using ref appropriate here, it constrains the usage of this struct pretty heavily, especially around async/await and lambdas.

Is it possible for us to implement a public ctor that throws and exception in DEBUG builds, but is optimized out for Release builds?

Is using ref appropriate here, it constrains the usage of this struct pretty heavily, especially around async/await and lambdas.

I can't think of any example where it would cause a problem, having in mind that this struct is supposed to be used as a pointer only.

Also it's easier to "unref" later on if we find out we were wrong than it is to add it back.

Is it possible for us to implement a public ctor that throws and exception in DEBUG builds, but is optimized out for Release builds?

Technically yes, with some help from the linker.

That said, using this struct in the wrong way is still safe, because if you create it like this:

var abl = new AudioBufferList ();

you'd get an AudioBufferList with 0 buffers (Count would return 0, and GetBuffer would always throw an IndexOutOfRangeException).

So I think going through a lot of trouble to add a public ctor that throws an exception for DEBUG builds is a bit more work than this problem warrants (also because a struct's public ctor won't always be called).

vs-mobiletools-engineering-service2 · 2024-09-11T21:41:14Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: be1e778751bef66ebdf2ed46050620d4f53be2d6 [PR build]

vs-mobiletools-engineering-service2 · 2024-09-11T21:45:27Z

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11) passed.

Pipeline on Agent
Hash: be1e778751bef66ebdf2ed46050620d4f53be2d6 [PR build]

vs-mobiletools-engineering-service2 · 2024-09-11T21:45:56Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: be1e778751bef66ebdf2ed46050620d4f53be2d6 [PR build]

vs-mobiletools-engineering-service2 · 2024-09-11T21:46:32Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: be1e778751bef66ebdf2ed46050620d4f53be2d6 [PR build]

vs-mobiletools-engineering-service2 · 2024-09-11T22:14:56Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: be1e778751bef66ebdf2ed46050620d4f53be2d6 [PR build]

vs-mobiletools-engineering-service2 · 2024-09-12T07:16:46Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 100 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 1 tests passed. Html Report (VSDrops) Download
✅ install-source: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ linker: All 40 tests passed. [attempt 2] Html Report (VSDrops) Download
⚠️ mac-binding-project: No tests selected. Html Report (VSDrops) Download
⚠️ mmp: No tests selected. Html Report (VSDrops) Download
⚠️ mononative: No tests selected. Html Report (VSDrops) Download
✅ monotouch (iOS): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 7 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
⚠️ mtouch: No tests selected. Html Report (VSDrops) Download
⚠️ xammac: No tests selected. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: be1e778751bef66ebdf2ed46050620d4f53be2d6 [PR build]

vs-mobiletools-engineering-service2 · 2024-09-12T13:10:19Z

✅ API diff for current PR / commit

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

✅ API diff vs stable

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: be1e778751bef66ebdf2ed46050620d4f53be2d6 [PR build]

rolfbjarne and others added 2 commits August 30, 2024 16:12

[Phase] Implement Xcode 16.0 beta 1-6 changes.

8c39190

Note: there were no changes in beta 2, beta 3, beta 4, beta 5 or beta 6.

Auto-format source code

f636cc2

This comment has been minimized.

Sign in to view

rolfbjarne added 2 commits September 4, 2024 12:19

Merge remote-tracking branch 'origin/xcode16' into dev/rolf/xcode16-b…

571f2e2

…1-phase

Skip legacy

65a3fe6

This comment has been minimized.

Sign in to view

rolfbjarne added 2 commits September 11, 2024 12:45

Merge remote-tracking branch 'origin/xcode16' into dev/rolf/xcode16-b…

e2cc439

…1-phase

Improve documentation.

d9849da

rolfbjarne marked this pull request as ready for review September 11, 2024 10:58

rolfbjarne requested a review from dalexsoto as a code owner September 11, 2024 10:58

Make 'readonly ref' to limit usage.

be1e778

dalexsoto approved these changes Sep 11, 2024

View reviewed changes

mcumming approved these changes Sep 11, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne merged commit f009530 into xcode16 Sep 12, 2024
18 of 20 checks passed

rolfbjarne deleted the dev/rolf/xcode16-b1-phase branch September 12, 2024 13:12

[Phase] Implement Xcode 16.0 beta 1-6 changes. #21156

[Phase] Implement Xcode 16.0 beta 1-6 changes. #21156

Conversation

rolfbjarne commented Aug 30, 2024 • edited Loading

github-actions bot commented Aug 30, 2024

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mcumming Sep 11, 2024

Choose a reason for hiding this comment

mcumming Sep 11, 2024

Choose a reason for hiding this comment

rolfbjarne Sep 11, 2024

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Sep 11, 2024

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

vs-mobiletools-engineering-service2 commented Sep 11, 2024

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

vs-mobiletools-engineering-service2 commented Sep 11, 2024

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

vs-mobiletools-engineering-service2 commented Sep 11, 2024

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

vs-mobiletools-engineering-service2 commented Sep 11, 2024

💻 [CI Build] Windows Integration Tests passed 💻

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Sep 12, 2024

🚀 [CI Build] Test results 🚀

Test results

Tests counts

vs-mobiletools-engineering-service2 commented Sep 12, 2024

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

rolfbjarne commented Aug 30, 2024 •

edited

Loading