[dotnet] Make the RelativeMlaunchPath and XamarinRelativeSdkRootDirectory properties public. #21074
Conversation
…tory properties public. When VS (Windows) needs to figure out where the iOS SDK is located on disk on the Mac machine, the project is evaluated and the`_XamarinRelativeSdkRootDirectory` property is read. Unfortunately an MSBuild optimization recently occurred in VS, where they don't keep underscored properties around after the build, and thus the property XVS needs to inspect isn't there anymore. So make `_XamarinRelativeSdkRootDirectory` and `_RelativeMlaunchPath` public properties by removing the underscore. Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/2220369.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
📚 [CI Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
❌ [CI Build] Windows Integration Tests failed ❌❌ Failed ❌ Pipeline on Agent |
|
/sudo backport release/8.0.1xx-xcode15.4 |
|
Backport Job to branch release/8.0.1xx-xcode15.4 Created! The magic is happening here |
|
/sudo backport release/9.0.1xx-rc1 |
|
Backport Job to branch release/9.0.1xx-rc1 Created! The magic is happening here |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10076074 for more details. |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10076090 for more details. |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
… XamarinRelativeSdkRootDirectory properties public. (#21078) When VS (Windows) needs to figure out where the iOS SDK is located on disk on the Mac machine, the project is evaluated and the`_XamarinRelativeSdkRootDirectory` property is read. Unfortunately an MSBuild optimization recently occurred in VS, where they don't keep underscored properties around after the build, and thus the property XVS needs to inspect isn't there anymore. So make `_XamarinRelativeSdkRootDirectory` and `_RelativeMlaunchPath` public properties by removing the underscore. Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/2220369. Backport of #21074 --------- Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
…inRelativeSdkRootDirectory properties public. (#21079) When VS (Windows) needs to figure out where the iOS SDK is located on disk on the Mac machine, the project is evaluated and the`_XamarinRelativeSdkRootDirectory` property is read. Unfortunately an MSBuild optimization recently occurred in VS, where they don't keep underscored properties around after the build, and thus the property XVS needs to inspect isn't there anymore. So make `_XamarinRelativeSdkRootDirectory` and `_RelativeMlaunchPath` public properties by removing the underscore. Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/2220369. Backport of #21074
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 168 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
rolfbjarne
deleted the
dev/rolf/public-xamarin-relative-sdk-root-directory
branch
When VS (Windows) needs to figure out where the iOS SDK is located on disk on
the Mac machine, the project is evaluated and
the
_XamarinRelativeSdkRootDirectoryproperty is read. Unfortunately anMSBuild optimization recently occurred in VS, where they don't keep
underscored properties around after the build, and thus the property XVS needs
to inspect isn't there anymore.
So make
_XamarinRelativeSdkRootDirectoryand_RelativeMlaunchPathpublicproperties by removing the underscore.
Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/2220369.