This repository has been archived by the owner on May 1, 2024. It is now read-only.
[XamlC] Support variance #8535
Merged
[XamlC] Support variance #8535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephaneDelcroix
approved these changes
Dec 18, 2019
|
could you rebase to fix the conflict ? thanks |
akihikodaki
force-pushed
the
variance
branch
from
d7d525b to
e506eb5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Variance matters even for basic interfaces like
System.Collections.Generic.IEnumerable<T>. I think XamlC will cover most use cases of generics with this change and previous improvements.Issues Resolved
None
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Run the automated tests.
PR Checklist