This repository has been archived by the owner on May 1, 2024. It is now read-only.
[UWP] Clean up "backButton" stuff in PageControl #3076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samhouts
added
p/UWP
t/housekeeping ♻︎
rmarinho
approved these changes
Jun 19, 2018
|
(retargeted to master) |
samhouts
approved these changes
Jun 25, 2018
hartez
force-pushed
the
pagecontrol-cleanup
branch
from
e54db44 to
6d35a2a
Compare
hartez
force-pushed
the
pagecontrol-cleanup
branch
from
6d35a2a to
ff8663e
Compare
samhouts
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The UWP PageControl class contains code to manage the back button, but the back button it manages does not exist anywhere in the template. It looks like this is code left over from handling Windows 8.1 TabletResources.
No automated tests, there's literally nothing to test for.
Issues Resolved
None
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
PR Checklist