This repository has been archived by the owner on May 1, 2024. It is now read-only.
Multi classes #134
Merged
Multi classes #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ClassStyle?.Apply(bindable); | ||
| if (ClassStyles != null) | ||
| foreach (var classStyle in ClassStyles) | ||
| ((IStyle)classStyle)?.Apply(bindable); |
There was a problem hiding this comment.
isn't it better (classStyle as IStyle)?.Apply
There was a problem hiding this comment.
No, it should NOT be
|
Left a comment but non blocking |
|
👍 |
mattleibow
added a commit
that referenced
this pull request
Jan 28, 2021
* Cleaned up the API a bit: - removed unnecessary static fields - removed unnecessary braces - a few other tweaks to reduce weird line wraps * Stopping the sensors requires that they are actually supported. * Added hardware traits to the tests to avoid evil code * Fixed some more tests. * We need to keep a reference to the sensors. * Android needs to filter some events to avoid large amounts of unnecessary updates * Gyroscopes are not emulated for Android
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
VisualElement supports a list of StyleClass, so you can have
Bugs Fixed
I do not fix bugs, I create them
API Changes
Changed:
Behavioral Changes
/
PR Checklist