-
Notifications
You must be signed in to change notification settings - Fork 501
Conversation
❌ Validation status: errors
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
This was an update PR, but I forgot to actually create it. This PR now just cleans up the .csproj, removing the multiple |
@@ -51,7 +51,7 @@ | |||
<Compile Include="**\*.netstandard.*.cs" /> | |||
</ItemGroup> | |||
<ItemGroup Condition=" $(TargetFramework.StartsWith('uap10.0')) "> | |||
<PackageReference Include="Microsoft.NETCore.UniversalWindowsPlatform" Version="6.0.6" /> | |||
<PackageReference Include="Microsoft.NETCore.UniversalWindowsPlatform" Version="6.1.5" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to bump to this? I assume it is okay? will it align with templates and does it require specific versions of .NET Core to be installed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not related to .net core (MS just used that name for some reason). This is the new version in the templates: https://github.com/xamarin/xamarin-templates/search?q=UniversalWindowsPlatform&unscoped_q=UniversalWindowsPlatform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should just sync with @pierceboggan to make sure our templates use this version too.
✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
Description of Change
Updating the NuGet versions and cleaned the project files.
Bugs Fixed
API Changes
None.
Behavioral Changes
None.
PR Checklist