feat: Add Heartbeat to updater #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
df-wg
commented
Oct 8, 2024
StarpTech
requested changes
Oct 8, 2024
v2/pkg/engine/datasource/graphql_datasource/graphql_sse_handler.go
Outdated
Show resolved
Hide resolved
v2/pkg/engine/datasource/graphql_datasource/graphql_subscription_client.go
Outdated
Show resolved
Hide resolved
v2/pkg/engine/datasource/graphql_datasource/graphql_ws_handler.go
Outdated
Show resolved
Hide resolved
StarpTech
reviewed
Oct 9, 2024
…artbeats to keep the connection alive
df-wg
force-pushed
the
dave/eng-5695-implement-graphql-subscriptions-over-multipart
branch
from
cd10850
to
afdebf2
Compare
StarpTech
reviewed
Oct 9, 2024
| @@ -81,6 +81,73 @@ func TestGraphQLSubscriptionClientSubscribe_SSE(t *testing.T) { | |||
| serverCancel() | |||
| } | |||
|
|
|||
| func TestGraphQLSubscriptionClientSubscribe_Heartbeat(t *testing.T) { | |||
| if flags.IsWindows { | |||
df-wg
deleted the
dave/eng-5695-implement-graphql-subscriptions-over-multipart
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used in wundergraph/cosmo#1227, specifically so that all of the subscriptions can create heartbeats to keep connections alive. This is a necessary step for supporting https://www.apollographql.com/docs/graphos/routing/operations/subscriptions/multipart-protocol#executing-a-subscription