Fix time label when time is more than an hour #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why are we showing milliseconds there? Seems unnecessary. |
renderer/utils/format-time.js
Outdated
| }; | ||
|
|
||
| const format = (time, {showMilliseconds} = {}) => { | ||
| const formatString = `${time >= 60 * 60 ? 'h:m' : ''}m:ss${showMilliseconds ? '.SS' : ''}`; |
There was a problem hiding this comment.
Not related to this PR, but I think we should show it as
Suggested change
| const formatString = `${time >= 60 * 60 ? 'h:m' : ''}m:ss${showMilliseconds ? '.SS' : ''}`; | |
| const formatString = `${time >= 60 * 60 ? 'hh:mm' : ''}mm:ss${showMilliseconds ? '.SS' : ''}`; |
This is how most video players show duration.
There was a problem hiding this comment.
I think you meant this:
Suggested change
| const formatString = `${time >= 60 * 60 ? 'h:m' : ''}m:ss${showMilliseconds ? '.SS' : ''}`; | |
| const formatString = `${time >= 60 * 60 ? 'h:' : ''}mm:ss${showMilliseconds ? '.SS' : ''}`; |
right? Otherwise if it's more than an hour the format becomes hh:mmmm:ss
There was a problem hiding this comment.
I meant:
Suggested change
| const formatString = `${time >= 60 * 60 ? 'h:m' : ''}m:ss${showMilliseconds ? '.SS' : ''}`; | |
| const formatString = `${time >= 60 * 60 ? 'hh:m' : ''}m:ss${showMilliseconds ? '.SS' : ''}`; |
|
I'm not sure about the milliseconds. I've never found it useful, but it was like that since Kap 2.x, so I just kept the logic during the rewrite. I'm ok with removing them. |
|
Yeah, let's try removing it and see if anyone complains. |
|
Removed milliseconds and changed the format 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #893