Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theta_m enhancements: re-enable use_theta_m, allow DA to work #452

Merged
merged 2 commits into from
Apr 25, 2018
Merged

theta_m enhancements: re-enable use_theta_m, allow DA to work #452

merged 2 commits into from
Apr 25, 2018

Conversation

davegill
Copy link
Contributor

@davegill davegill commented Apr 14, 2018 •
edited
Loading

TYPE: enhancement

KEYWORDS: use_theta_m, thetam

SOURCE: internal

DESCRIPTION OF CHANGES:

  1. All of the places that use moist theta, put in an if test to determine if the user has requested dry theta for the variable used in the dynamics.
  2. Add perturbation dry potential temp to the wrfinput stream for diagnostic purposes.
  3. The combination of these two options allows DA to work (when use_theta_m=0).

LIST OF MODIFIED FILES:
M dyn_em/module_big_step_utilities_em.F
M dyn_em/module_initialize_real.F
M dyn_em/solve_em.F
M Registry/Registry.EM_COMMON

TESTS CONDUCTED:

  • Multiple 12-h, nested, Jan 30/10 km cases have reasonable results, with use_theta_m =0 or 1.

  1. CG - dry potential temp, k=1
    screen shot 2018-04-13 at 6 01 37 pm

  2. CG - Qv, k=1
    screen shot 2018-04-13 at 6 02 46 pm

  3. CG - MU
    screen shot 2018-04-13 at 6 04 16 pm

  4. CG - RAINNC
    screen shot 2018-04-13 at 6 05 17 pm

  5. FG - dry potential temp, k=1
    screen shot 2018-04-13 at 6 07 44 pm

  6. FG - Qv, k=1
    screen shot 2018-04-13 at 6 09 13 pm

  7. FG - MU
    screen shot 2018-04-13 at 6 10 29 pm

  8. FG - RAINNC
    screen shot 2018-04-13 at 6 11 23 pm

davegill added 2 commits April 13, 2018 18:12
@davegill
Re-enable use_theta_m switch
c02510c 
TYPE: enhancement

KEYWORDS: use_theta_m, thetam

SOURCE: internal

DESCRIPTION OF CHANGES:
All of the places that use moist theta, put in an if test to determine if the user has requested dry theta for the variable used in the dynamics.

LIST OF MODIFIED FILES:
M   dyn_em/module_big_step_utilities_em.F
M   dyn_em/module_initialize_real.F
M   dyn_em/solve_em.F

TESTS CONDUCTED:
 - [x] Multiple 12-h, nested, Jan 30/10 km cases have reasonable results, with use_theta_m =0 or 1.
@davegill
Put dry perturbation potential temp in wrfinput stream
197df24
@davegill
Copy link
Contributor Author

@kkeene44
Kelly,
This PR will allow you to run with use_theta_m = 0 or 1. You can test your idealized theta_m mods.

@davegill
Copy link
Contributor Author

@liujake
Jake,
This PR should work with 3dvar cycling, if you turn off moist theta (use_theta_m=0).

@davegill
Copy link
Contributor Author

@smileMchen
Ming,
This PR puts the dry perturbation potential temperature in the wrfinput file. If you need that variable for your month-long verification, then you'll need this PR.

@kkeene44
Copy link
Collaborator

@weiwangncar
Do you think it's okay for us to approve this, so that I can do the PR I need to, with the change?

@liujake
Copy link
Contributor

liujake commented Apr 18, 2018

I think it will be good to approve it and push it in so that WTF can run and then I can try DA with this option.

@kkeene44
Copy link
Collaborator

@liujake
I ran a regression test on it and a LOT of things failed. I'm able to simply re-run some of the tests, but some things (e.g., chem, wrfda_4dvar) I cannot get to build. I've had a lot of problems, in general, with all of my WTF tests running out of wallclock time, so I'm not sure what's going on - it wouldn't surprise me if half of the problem was Cheyenne. Regardless, I'm not sure we should approve it until we can get past these failures.

dudhia
dudhia approved these changes Apr 25, 2018
View reviewed changes
Copy link
Collaborator

@dudhia dudhia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@davegill davegill merged commit a20e824 into wrf-model:master Apr 25, 2018
@kkeene44 kkeene44 mentioned this pull request Apr 26, 2018
Merged
davegill pushed a commit that referenced this pull request Apr 30, 2018
@kkeene44 @davegill
add if use_theta_m test around loop for turning dry pot temp to moist…
821007f 
… pot temp (#460)

TYPE: bug fix

KEYWORDS: use_theta_m, dry, moist, potential_temp, 

SOURCE: Internal

DESCRIPTION OF CHANGES: In each module_initialize_<ideal_case> file, there is a do loop that turns dry potential temperature into moist potential temperature to work with the implementation of theta_m. This caused problems for some applications (e.g., wrfda), therefore it was necessary to add an 'if' test around this loop to question whether theta_m is being used.

Plots attached showing difference in T, MOIST_THETA-T0, and QVAPOR between having use_theta_m set to 0 vs. 1

![use_theta_m_0_moist_theta-to](https://user-images.githubusercontent.com/21043917/39334561-6427af52-496c-11e8-9f7f-968db960f0ff.png)
![use_theta_m_0_qvapor](https://user-images.githubusercontent.com/21043917/39334562-643a20a6-496c-11e8-8093-27e3759d743c.png)
![use_theta_m_0_t](https://user-images.githubusercontent.com/21043917/39334563-64525c20-496c-11e8-9bd4-8d0b06c921af.png)
![use_theta_m_1_moist_theta-t0](https://user-images.githubusercontent.com/21043917/39334564-6469bd0c-496c-11e8-8b59-20770e60ed3e.png)
![use_theta_m_1_qvapor](https://user-images.githubusercontent.com/21043917/39334565-64813d42-496c-11e8-8faf-40d66e1b8926.png)
![use_theta_m_1_t](https://user-images.githubusercontent.com/21043917/39334566-6497812e-496c-11e8-91a3-c013b81d59ed.png)

Associated with the same changes introduced for the real-data processor in PR #452, SHA-1 a20e824.

LIST OF MODIFIED FILES: 
M     dyn_em/module_initialize_fire.F
M     dyn_em/module_initialize_heldsuarez.F
M     dyn_em/module_initialize_ideal.F
M     dyn_em/module_initialize_scm_xy.F
M     dyn_em/module_initialize_tropical_cyclone.F

TESTS CONDUCTED: passes WTF
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudhia dudhia dudhia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davegill @kkeene44 @liujake @dudhia