-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for title attribute #51
Comments
How would this work? are we talking url or site title? I'm happy to look into is I can get some guideline around the end goal. Maybe show an example or your exxpected output and I can look into getting it in |
Sure thing @reganlawton , Here's an article on frames having title attributes: For implementation, it would ideally be a simple options parameter, something like this:
Which could result in something like this:
Ideally, it would just default to the title of the embedded media, if it exists ( |
Have you tried adding the title to the params options? I'd need to rest but I'm pretty sure that might work. |
Sorry, no that does not work. |
I'll have to run some tests today and figure this out. |
Give v1.3.6 a shot with the new attribute options. |
Hi there, this is great! The attributes solution makes it much more flexible too, nice work. Thanks so much for implementing - my current project has pages which can now complete Fast Pass accessibility validation. Do you have a beer buying button anywhere? 😃 Unfortunately, initially, I thought it wasn't working, but it appears I had an existing bug related to usage in matrix fields (sorry!) - I've reported this here. |
Was simple fix I've just been insanely busy so thank you for sticking in there 😅 |
To improve accessibility for screen readers, it's desirable to have a
title
attribute on the rendered iframe.Is there any chance support for this could be added? :)
Thanks 🙏
The text was updated successfully, but these errors were encountered: