Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oEmbed requires PHP 7.1.3+ #33

Closed
brandonkelly opened this issue Feb 5, 2020 · 5 comments
Closed

oEmbed requires PHP 7.1.3+ #33

brandonkelly opened this issue Feb 5, 2020 · 5 comments

Comments

@brandonkelly
Copy link

Ever since 1.2.0 (067706b), oEmbed requires laravel/helpers, which requires PHP >=7.1.3. That’s a bit of a problem because Craft installs currently require PHP 7.0-compatible dependencies: https://github.com/craftcms/craft/blob/master/composer.json.default#L14-L16

I couldn’t tell from that commit what you’re actually using the laravel/heplers package for. If you can show me, I might be able to offer an alternative approach that doesn’t require that package.

@reganlawton
Copy link
Member

Hmm... @brandonkelly what ever I use it for I can pull it out and replace with vanilla, or use a PHP 7.0-compatible of the helpers library. This shouldn't be an issue at all and happy to fall inline with Craft's support.

@reganlawton
Copy link
Member

@brandonkelly can you check dev-feature/php7 and confirm that it's up to your minium PHP requirements.

@brandonkelly
Copy link
Author

That appears to have solved it! So I take it you weren’t using anything from laravel/helpers in the first place?

@reganlawton
Copy link
Member

Original yes I was but I removed the feature that used the helpers and didn’t remove the package in case I needed the helpers, such as collections, etc in future features. I’ll merge this into master and tag a new release.

@brandonkelly
Copy link
Author

Thanks @reganlawton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants