Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined index: autoplay #26

Closed
hannahwoodward opened this issue Dec 18, 2019 · 6 comments
Closed

Undefined index: autoplay #26

hannahwoodward opened this issue Dec 18, 2019 · 6 comments

Comments

@hannahwoodward
Copy link

After performing some routine CMS & plugin updates on Craft, Sentry has started reporting an error for the oembed plugin, happening from both editing an entry and in the templates on entries that are using the oembed field.

https://sentry.io/share/issue/c4683affddff40c3bdcaad1ce37dffd7/
https://sentry.io/share/issue/d67205af7c234e058c4672eaf199ecf8/

Plugins updated:

  • Craft (3.3.18.3)
  • Sentry (1.0.2)
  • Seomatic (3.2.37)
  • Freeform (3.5.8)

Craft Version: 3.3.18.3
oEmbed Version: 1.1.8
@reganlawton
Copy link
Member

I can see the issue here it’s that the array key is being called. A quick quick is to past auto play as an option till I can rest a new version tomorrow with the required empty() check.

@hannahwoodward
Copy link
Author

Thanks! The site hasn't broken so it's not super urgent, just thought I'd forward on the error.

@reganlawton
Copy link
Member

Argh I think I might it’s cos I put it in a try-finally and not handling the catch. It still needs to be fixed regardless I have time assigned over the holidays to make a few updates to all my plugins.

@hannahwoodward
Copy link
Author

Any update on this?

@reganlawton
Copy link
Member

@hannahwoodward I'm truely sorry about this! I was working completely over the holidays due to a crazy project, even XMAS 😅

I'll try get this attacked tonight!

reganlawton added a commit that referenced this issue Jan 19, 2020
@reganlawton
v1.2.0
067706b 
### Updated
- Support `rel` URL propety via DOM manipulation. ([#24](#24))
- Added GraphQL support. ([#25](#25))
- Updated docs

### Fixed
- Fixed "Undefined index: autoplay" warnings. ([#26](#26))
@reganlawton reganlawton mentioned this issue Jan 19, 2020
Merged
@reganlawton
Copy link
Member

@hannahwoodward I've pushed out a release v1.2.0 which should have you issue resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reganlawton @hannahwoodward