Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login mutation registered using pre register_graphql_* API technique #49

Closed
jasonbahl opened this issue Oct 16, 2019 · 1 comment
Closed
Assignees

Comments

@jasonbahl
Copy link
Collaborator

The way the login mutation is registered in this plugin doesn't play nice with the centralized filters the rest of WPGraphQL benefit from.

For example, there's no way to register additional fields to the login payload, because it doesn't pass through the WPInputObject type and filters are not applied.

To fix this, we should convert the mutation to use register_graphql_mutation

jasonbahl added a commit to jasonbahl/wp-graphql-jwt-authentication that referenced this issue Oct 16, 2019
…_graphql_mutation`

- also fixes some test issues
jasonbahl added a commit to jasonbahl/wp-graphql-jwt-authentication that referenced this issue Oct 18, 2019
jasonbahl added a commit that referenced this issue Oct 18, 2019
@jasonbahl
Copy link
Collaborator Author

closed by v0.3.4 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants