[Stats Refresh] Insights Latest Post Summary: update design #11289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 tasks
jklausa
approved these changes
Mar 16, 2019
| @@ -168,7 +168,7 @@ private extension OverviewCell { | |||
| ]) | |||
| } | |||
|
|
|||
| private enum ChartBottomMargin { | |||
| enum ChartBottomMargin { | |||
There was a problem hiding this comment.
Unless I'm blind (and my cmd-f has broken) nothing else in this PR references ChartBottomMargin — why the change here?
There was a problem hiding this comment.
Oh, sorry, I failed to commit this separately. I just noticed this private was unnecessary since this enum is in a private extension, so I removed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11284
This updates Insights Latest Post Summary to match the new design:
To test:
LatestPostSummaryCell:configure, you can modify the value used in this line:viewsDataLabel.text = lastPostInsight.viewsCount.abbreviatedString(forHeroNumber: true)