Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python 2 Support #66

Closed
bethune-bryant opened this issue Jul 18, 2019 · 4 comments
Closed

Drop Python 2 Support #66

bethune-bryant opened this issue Jul 18, 2019 · 4 comments
Assignees
@wookayin @Stonesjtu
Labels
enhancement
Milestone
1.0

Comments

@bethune-bryant
Copy link
Contributor

@Stonesjtu Pointed out that Python 2 is being retired:

python2.7 is retiring in Jan 1st 2020, so probably the master branch can focus on only python 3.
Ref. https://pythonclock.org/

According to https://stackoverflow.com/questions/40114100/uploading-different-versions-python-2-7-vs-3-5-to-pypi, we can simply add python_requires='>=3.4' and bump the version.
Then if you install the package via pip2, the out-dated one instead of the newest version will be selected.
@bethune-bryant bethune-bryant mentioned this issue Jul 18, 2019
Merged
@bethune-bryant bethune-bryant mentioned this issue Jul 18, 2019
Closed
@wookayin
Copy link
Owner

Speaking of retiring python2, I think this would be the best time to version our gpustat finally as 1.0.

@bethune-bryant
Copy link
Contributor Author

Speaking of retiring python2, I think this would be the best time to version our gpustat finally as 1.0.

@wookayin

Let me know if there's anything you want me to do for this.

@ofek
Copy link

ofek commented Jul 22, 2019

@wookayin Then you could also resolve #57 by using https://docs.python.org/3/library/shutil.html#shutil.get_terminal_size

@wookayin wookayin added this to the 1.0 milestone Jul 22, 2019
@wookayin wookayin changed the title Stop Supporting Python 2 Drop Python 2 Support Jul 23, 2019
@bethune-bryant
Copy link
Contributor Author

Resolved by #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wookayin wookayin

@Stonesjtu Stonesjtu

Labels
enhancement
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Stop supporting Python 2 bethune-bryant/gpustat
4 participants
@wookayin @Stonesjtu @ofek @bethune-bryant