-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Shipping labels] Edit selected package #14713
Conversation
📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.
|
Preselect correct tabs for previously selected package
3f15f64
to
817882a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to scroll to selected package when we edit selected package?
In this example I select a starred/saved carrier package and when I go to edit it, the saved list is showed but that selected package is not visible.
Maybe we can leave that for a separate PR?
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-19.at.16.53.28.mp4
…t-selected-package
Good idea, tracked in #14734. |
Part of: #14522
⚠️ Depends on #14711 ⚠️
Description
This PR handles editing the selected package in the Woo Shipping label flow. After selecting a package, you can tap the pencil icon to select a different package.
How
WooShippingSelectedPackageView
now opensWooShippingAddPackageView
with the previously selected package data when the pencil icon is tapped. It also has anupdateSelectedPackage
closure that is used to update the selected package inWooShippingCreateLabelsViewModel
if a new package is selected.WooShippingAddCustomPackageViewModel
now accepts a preselected package:WooShippingAddPackageViewModel
now accepts a selected package:Testing information
Screenshots
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-17.at.16.32.04.mp4
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: