Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Product Global Unique Identifier] Refine Barcode Scanner Search #14712

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

toupper
Copy link
Contributor

@toupper toupper commented Dec 17, 2024

Closes: #14332

Description

With this PR we refine the barcode scan behavior by prioritising the global unique identifier over the SKU. On top of that, we trigger both requests in parallel to speed the process.

Steps to reproduce

  1. Assign the same identifier to a product SKU and a different product GTIN
  2. Go to orders
  3. Tap on the barcode scanner
  4. Scan that identifier
  5. See how the GTIN product is added

Testing information

I also verified that the product is properly added when the identifier is assigned to the SKU

Screenshots

N/A


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@toupper toupper added type: task An internally driven task. feature: product details Related to adding or editing products, including Product Settings. labels Dec 17, 2024
@toupper toupper added this to the 21.3 milestone Dec 17, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 17, 2024

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14712-f8ec465
Version21.2
Bundle IDcom.automattic.alpha.woocommerce
Commitf8ec465
App Center BuildWooCommerce - Prototype Builds #12203
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 21.3. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@toupper toupper merged commit 673a61f into trunk Dec 19, 2024
12 checks passed
@toupper toupper deleted the issue/14332-refine-gtin-barcode-scanner-search branch December 19, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: product details Related to adding or editing products, including Product Settings. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add value in Barcode Scanner Search
3 participants